From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Tue, 1 Aug 2023 11:49:50 +0000 (+0200)
Subject: lmdbbackend: Prevent a useless copy in LMDBBackend::getAllDomainsFiltered()
X-Git-Tag: rec-5.0.0-alpha1~77^2~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5b06f2979dff69a0856033b17ece00775af1599f;p=thirdparty%2Fpdns.git

lmdbbackend: Prevent a useless copy in LMDBBackend::getAllDomainsFiltered()

Reported by Coverity as 1510936: AUTO_CAUSES_COPY.
---

diff --git a/modules/lmdbbackend/lmdbbackend.cc b/modules/lmdbbackend/lmdbbackend.cc
index d47904815d..11168f3266 100644
--- a/modules/lmdbbackend/lmdbbackend.cc
+++ b/modules/lmdbbackend/lmdbbackend.cc
@@ -1722,9 +1722,9 @@ void LMDBBackend::getAllDomainsFiltered(vector<DomainInfo>* domains, const std::
       zonemap[di.zone] = di;
     }
 
-    for (auto [k, v] : zonemap) {
+    for (auto& [k, v] : zonemap) {
       if (allow(v)) {
-        domains->push_back(v);
+        domains->push_back(std::move(v));
       }
     }
   }