From: Christian Brauner <christian.brauner@ubuntu.com>
Date: Thu, 25 Mar 2021 07:23:25 +0000 (+0100)
Subject: confile_utils: don't free netdev twice
X-Git-Tag: lxc-5.0.0~249^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5b1030e26ca9b925ea4f9f79c4939958474806db;p=thirdparty%2Flxc.git

confile_utils: don't free netdev twice

lxc_free_netdev() will already free the list element.

Fixes: https://github.com/google/oss-fuzz/pull/5498
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
---

diff --git a/src/lxc/confile_utils.c b/src/lxc/confile_utils.c
index 899b58341..78f82267e 100644
--- a/src/lxc/confile_utils.c
+++ b/src/lxc/confile_utils.c
@@ -465,7 +465,6 @@ bool lxc_remove_nic_by_idx(struct lxc_conf *conf, unsigned int idx)
 			continue;
 
 		lxc_list_del(cur);
-		free(cur);
 		return true;
 	}
 
@@ -480,7 +479,6 @@ void lxc_free_networks(struct lxc_list *networks)
 		struct lxc_netdev *netdev = cur->elem;
 		netdev = cur->elem;
 		lxc_free_netdev(netdev);
-		free(cur);
 	}
 
 	/* prevent segfaults */