From: Zhilong Liu Date: Thu, 30 Mar 2017 07:38:08 +0000 (+0800) Subject: mdadm/grow: reshape would be stuck from raid1 to raid5 X-Git-Tag: mdadm-4.1-rc1~221 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5b2846684ef5172eccc432e3520b79efbc2abba5;p=thirdparty%2Fmdadm.git mdadm/grow: reshape would be stuck from raid1 to raid5 systemctl doesn't interpret mdadm-grow-continue@.service correctly due to the wrong argument provided in [service], it should be corrected %I as %i. Otherwise, if the service cannot start by systemctl and the reshap progress would be stuck all time when grows array from raid1 to raid5. reproduce steps: ./mdadm -CR /dev/md0 -l1 -b internal -n2 /dev/loop[0-1] ./mdadm --grow /dev/md0 -l5 -n3 -a /dev/loop2 Signed-off-by: Zhilong Liu Signed-off-by: Jes Sorensen --- diff --git a/systemd/mdadm-grow-continue@.service b/systemd/mdadm-grow-continue@.service index 5c667d2a..882bc0b0 100644 --- a/systemd/mdadm-grow-continue@.service +++ b/systemd/mdadm-grow-continue@.service @@ -10,7 +10,7 @@ Description=Manage MD Reshape on /dev/%I DefaultDependencies=no [Service] -ExecStart=BINDIR/mdadm --grow --continue /dev/%I +ExecStart=BINDIR/mdadm --grow --continue /dev/%i StandardInput=null StandardOutput=null StandardError=null