From: Ruediger Pluem <rpluem@apache.org>
Date: Fri, 7 Nov 2025 08:23:08 +0000 (+0000)
Subject: Merge r1873397 from trunk:
X-Git-Tag: 2.4.66-rc1-candidate~23
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5b4ba1e8d504cee21e41b50652302df86ba01b02;p=thirdparty%2Fapache%2Fhttpd.git

Merge r1873397 from trunk:

PR62989: DOCTYPE tags in server-generated HTML.

Submitted By: Andra Farkas <deepbluemistake gmail.com>, Giovanni Bechis <giovanni paclan.it>
Reviewed by: rpluem, jorton, covener

Github: closes #553


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1929571 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/CHANGES b/CHANGES
index 08b31199419..f608213a84b 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,6 +1,27 @@
                                                          -*- coding: utf-8 -*-
 Changes with Apache 2.4.66
 
+  *) mod_ssl: Add SSLVHostSNIPolicy directive to control the virtual
+     host compatibility policy.  PR 69743.  [Joe Orton]
+
+  *) mod_md: update to version 2.6.2
+     - Fix error retry delay calculation to not already doubling the wait
+       on the first error.
+
+  *) mod_md: update to version 2.6.1
+     - Increasing default `MDRetryDelay` to 30 seconds to generate less bursty
+       traffic on errored renewals for the ACME CA. This leads to error retries
+        of 30s, 1 minute, 2, 4, etc. up to daily attempts.
+     - Checking that configuring `MDRetryDelay` will result in a positive
+       duration. A delay of 0 is not accepted.
+     - Fix a bug in checking Content-Type of responses from the ACME server.
+     - Added ACME ARI support (rfc9773) to the module. Enabled by default. New
+       directive "MDRenewViaARI on|off" for controlling this.
+     - Removing tailscale support. It has not been working for a long time
+       as the company decided to change their APIs. Away with the dead code,
+       documentation and tests.
+     - Fixed a compilation issue with pre-industrial versions of libcurl.
+
 Changes with Apache 2.4.65
 
   *) SECURITY: CVE-2025-54090: Apache HTTP Server: 'RewriteCond expr'
diff --git a/STATUS b/STATUS
index 478fe7ea9e2..b655880142c 100644
--- a/STATUS
+++ b/STATUS
@@ -175,14 +175,6 @@ PATCHES ACCEPTED TO BACKPORT FROM TRUNK:
      2.4.x patch: svn merge -c 1927792 ^/httpd/httpd/trunk .
      +1: icing, rpluem, jorton
 
-  *) various: Update DOCTYPE tags in server-generated HTML to 4.01
-     Trunk version of patch:
-        https://svn.apache.org/r1873397
-     Backport version for 2.4.x of patch:
-       https://patch-diff.githubusercontent.com/raw/apache/httpd/pull/553.diff
-     Can be applied via apply_backport_pr.sh 553
-     +1: rpluem, jorton, covener
-
   *) mpm_common: Add new ListenTCPDeferAccept directive that allows to specify
      the value set for the TCP_DEFER_ACCEPT socket option on listen sockets.
      Trunk version of patch:
diff --git a/changes-entries/md_v2.6.1.txt b/changes-entries/md_v2.6.1.txt
deleted file mode 100644
index f3d1c30f8e3..00000000000
--- a/changes-entries/md_v2.6.1.txt
+++ /dev/null
@@ -1,13 +0,0 @@
-  *) mod_md: update to version 2.6.1
-     - Increasing default `MDRetryDelay` to 30 seconds to generate less bursty
-       traffic on errored renewals for the ACME CA. This leads to error retries
-        of 30s, 1 minute, 2, 4, etc. up to daily attempts.
-     - Checking that configuring `MDRetryDelay` will result in a positive
-       duration. A delay of 0 is not accepted.
-     - Fix a bug in checking Content-Type of responses from the ACME server.
-     - Added ACME ARI support (rfc9773) to the module. Enabled by default. New
-       directive "MDRenewViaARI on|off" for controlling this.
-     - Removing tailscale support. It has not been working for a long time
-       as the company decided to change their APIs. Away with the dead code,
-       documentation and tests.
-     - Fixed a compilation issue with pre-industrial versions of libcurl.
diff --git a/changes-entries/md_v2.6.2.txt b/changes-entries/md_v2.6.2.txt
deleted file mode 100644
index d5194c2ba09..00000000000
--- a/changes-entries/md_v2.6.2.txt
+++ /dev/null
@@ -1,3 +0,0 @@
-  *) mod_md: update to version 2.6.2
-     - Fix error retry delay calculation to not already doubling the wait
-       on the first error.
diff --git a/changes-entries/pr69743.txt b/changes-entries/pr69743.txt
deleted file mode 100644
index 72dfc8db0cf..00000000000
--- a/changes-entries/pr69743.txt
+++ /dev/null
@@ -1,3 +0,0 @@
-  *) mod_ssl: Add SSLVHostSNIPolicy directive to control the virtual
-     host compatibility policy.  PR 69743.  [Joe Orton]
-
diff --git a/docs/docroot/index.html b/docs/docroot/index.html
index f5f1c377b64..a4e4d11f560 100644
--- a/docs/docroot/index.html
+++ b/docs/docroot/index.html
@@ -1 +1,9 @@
-<html><body><h1>It works!</h1></body></html>
+<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">
+<html>
+<head>
+<title>It works! Apache httpd</title>
+</head>
+<body>
+<p>It works!</p>
+</body>
+</html>
diff --git a/include/httpd.h b/include/httpd.h
index b4305b09f2f..573ef18381d 100644
--- a/include/httpd.h
+++ b/include/httpd.h
@@ -249,6 +249,10 @@ extern "C" {
 #define DOCTYPE_HTML_4_0F "<!DOCTYPE HTML PUBLIC \"-//W3C//" \
                           "DTD HTML 4.0 Frameset//EN\"\n" \
                           "\"http://www.w3.org/TR/REC-html40/frameset.dtd\">\n"
+/** HTML 4.01 Doctype */
+#define DOCTYPE_HTML_4_01 "<!DOCTYPE HTML PUBLIC \"-//W3C//DTD HTML 4.01//EN\" \"http://www.w3.org/TR/html4/strict.dtd\">\n"
+/** HTML 5 Doctype */
+#define DOCTYPE_HTML_5 "<!DOCTYPE html>\n"
 /** XHTML 1.0 Strict Doctype */
 #define DOCTYPE_XHTML_1_0S "<!DOCTYPE html PUBLIC \"-//W3C//" \
                            "DTD XHTML 1.0 Strict//EN\"\n" \
diff --git a/modules/examples/mod_example_hooks.c b/modules/examples/mod_example_hooks.c
index d9379060681..6bdd9899648 100644
--- a/modules/examples/mod_example_hooks.c
+++ b/modules/examples/mod_example_hooks.c
@@ -1006,7 +1006,7 @@ static int x_handler(request_rec *r)
      * Now send our actual output.  Since we tagged this as being
      * "text/html", we need to embed any HTML.
      */
-    ap_rputs(DOCTYPE_HTML_3_2, r);
+    ap_rputs(DOCTYPE_HTML_4_01, r);
     ap_rputs("<HTML>\n", r);
     ap_rputs(" <HEAD>\n", r);
     ap_rputs("  <TITLE>mod_example_hooks Module Content-Handler Output\n", r);
diff --git a/modules/generators/mod_autoindex.c b/modules/generators/mod_autoindex.c
index 62804309ea6..715b49c7d74 100644
--- a/modules/generators/mod_autoindex.c
+++ b/modules/generators/mod_autoindex.c
@@ -179,7 +179,7 @@ static void emit_preamble(request_rec *r, int xhtml, const char *title)
                   " <head>\n  <title>Index of ", title,
                   "</title>\n", NULL);
     } else {
-        ap_rvputs(r, DOCTYPE_HTML_3_2,
+        ap_rvputs(r, DOCTYPE_HTML_4_01,
                   "<html>\n <head>\n"
                   "  <title>Index of ", title,
                   "</title>\n", NULL);
diff --git a/modules/generators/mod_status.c b/modules/generators/mod_status.c
index c1c856d41dd..f0cff67ac45 100644
--- a/modules/generators/mod_status.c
+++ b/modules/generators/mod_status.c
@@ -419,7 +419,7 @@ static int status_handler(request_rec *r)
     ap_get_loadavg(&t);
 
     if (!short_report) {
-        ap_rputs(DOCTYPE_HTML_3_2
+        ap_rputs(DOCTYPE_HTML_4_01
                  "<html><head>\n"
                  "<title>Apache Status</title>\n"
                  "</head><body>\n"
diff --git a/modules/http/http_protocol.c b/modules/http/http_protocol.c
index 3bc666e6d90..669a17d0b02 100644
--- a/modules/http/http_protocol.c
+++ b/modules/http/http_protocol.c
@@ -1520,7 +1520,7 @@ AP_DECLARE(void) ap_send_error_response(request_rec *r, int recursive_error)
          */
 
         ap_rvputs_proto_in_ascii(r,
-                  DOCTYPE_HTML_2_0
+                  DOCTYPE_HTML_4_01
                   "<html><head>\n<title>", title,
                   "</title>\n</head><body>\n<h1>", h1, "</h1>\n",
                   NULL);
diff --git a/modules/ldap/util_ldap.c b/modules/ldap/util_ldap.c
index 3795fd42806..cf57b3d23cc 100644
--- a/modules/ldap/util_ldap.c
+++ b/modules/ldap/util_ldap.c
@@ -176,7 +176,7 @@ static int util_ldap_handler(request_rec *r)
     if (r->header_only)
         return OK;
 
-    ap_rputs(DOCTYPE_HTML_3_2
+    ap_rputs(DOCTYPE_HTML_4_01
              "<html><head><title>LDAP Cache Information</title></head>\n", r);
     ap_rputs("<body bgcolor='#ffffff'><h1 align=center>LDAP Cache Information"
              "</h1>\n", r);
diff --git a/modules/mappers/mod_imagemap.c b/modules/mappers/mod_imagemap.c
index b2dca7e1ee7..66d10bbb8c0 100644
--- a/modules/mappers/mod_imagemap.c
+++ b/modules/mappers/mod_imagemap.c
@@ -477,7 +477,7 @@ static void menu_header(request_rec *r, char *menu)
 {
     ap_set_content_type_ex(r, "text/html; charset=ISO-8859-1", 1);
 
-    ap_rvputs(r, DOCTYPE_HTML_3_2, "<html><head>\n<title>Menu for ",
+    ap_rvputs(r, DOCTYPE_HTML_4_01, "<html><head>\n<title>Menu for ",
               ap_escape_html(r->pool, r->uri),
               "</title>\n</head><body>\n", NULL);
 
diff --git a/modules/proxy/mod_proxy_balancer.c b/modules/proxy/mod_proxy_balancer.c
index daec21ad6c3..f5b228f0e32 100644
--- a/modules/proxy/mod_proxy_balancer.c
+++ b/modules/proxy/mod_proxy_balancer.c
@@ -1620,7 +1620,7 @@ static void balancer_display_page(request_rec *r, proxy_server_conf *conf,
     }
     else {
         ap_set_content_type(r, "text/html; charset=ISO-8859-1");
-        ap_rputs(DOCTYPE_HTML_3_2
+        ap_rputs(DOCTYPE_HTML_4_01
                  "<html><head><title>Balancer Manager</title>\n", r);
         ap_rputs("<style type='text/css'>\n"
                  "table {\n"
diff --git a/modules/proxy/mod_proxy_ftp.c b/modules/proxy/mod_proxy_ftp.c
index 5175e455845..0e9c9b29e24 100644
--- a/modules/proxy/mod_proxy_ftp.c
+++ b/modules/proxy/mod_proxy_ftp.c
@@ -532,7 +532,7 @@ static apr_status_t proxy_send_dir_filter(ap_filter_t *f,
 
         /* print "ftp://host/" */
         escpath = ap_escape_html(p, path);
-        str = apr_psprintf(p, DOCTYPE_HTML_3_2
+        str = apr_psprintf(p, DOCTYPE_HTML_4_01
                 "<html>\n <head>\n  <title>%s%s%s</title>\n"
                 "<base href=\"%s%s%s\">\n"
                 " </head>\n"