From: Peter Christensen Date: Thu, 8 May 2014 09:15:37 +0000 (+0200) Subject: macvlan: Don't propagate IFF_ALLMULTI changes on down interfaces. X-Git-Tag: v3.2.60~71 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5b64df7dd898e1b05ecb77d06a69313a9d7c43db;p=thirdparty%2Fkernel%2Fstable.git macvlan: Don't propagate IFF_ALLMULTI changes on down interfaces. [ Upstream commit bbeb0eadcf9fe74fb2b9b1a6fea82cd538b1e556 ] Clearing the IFF_ALLMULTI flag on a down interface could cause an allmulti overflow on the underlying interface. Attempting the set IFF_ALLMULTI on the underlying interface would cause an error and the log message: "allmulti touches root, set allmulti failed." Signed-off-by: Peter Christensen Signed-off-by: David S. Miller Signed-off-by: Ben Hutchings --- diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index ab5786b49d5fe..b74cdf6a0d7d7 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -391,8 +391,10 @@ static void macvlan_change_rx_flags(struct net_device *dev, int change) struct macvlan_dev *vlan = netdev_priv(dev); struct net_device *lowerdev = vlan->lowerdev; - if (change & IFF_ALLMULTI) - dev_set_allmulti(lowerdev, dev->flags & IFF_ALLMULTI ? 1 : -1); + if (dev->flags & IFF_UP) { + if (change & IFF_ALLMULTI) + dev_set_allmulti(lowerdev, dev->flags & IFF_ALLMULTI ? 1 : -1); + } } static void macvlan_set_multicast_list(struct net_device *dev)