From: Johan Hovold Date: Mon, 6 Mar 2017 16:36:38 +0000 (+0100) Subject: USB: serial: omninet: fix reference leaks at open X-Git-Tag: v3.12.73~124 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5b6983c42e4406e92b51a705c24190e1054cb60d;p=thirdparty%2Fkernel%2Fstable.git USB: serial: omninet: fix reference leaks at open commit 30572418b445d85fcfe6c8fe84c947d2606767d8 upstream. This driver needlessly took another reference to the tty on open, a reference which was then never released on close. This lead to not just a leak of the tty, but also a driver reference leak that prevented the driver from being unloaded after a port had once been opened. Fixes: 4a90f09b20f4 ("tty: usb-serial krefs") Signed-off-by: Johan Hovold Signed-off-by: Jiri Slaby --- diff --git a/drivers/usb/serial/omninet.c b/drivers/usb/serial/omninet.c index 24720f6563874..8028e5ffe80d0 100644 --- a/drivers/usb/serial/omninet.c +++ b/drivers/usb/serial/omninet.c @@ -143,12 +143,6 @@ static int omninet_port_remove(struct usb_serial_port *port) static int omninet_open(struct tty_struct *tty, struct usb_serial_port *port) { - struct usb_serial *serial = port->serial; - struct usb_serial_port *wport; - - wport = serial->port[1]; - tty_port_tty_set(&wport->port, tty); - return usb_serial_generic_open(tty, port); }