From: Christian Brauner <christian.brauner@ubuntu.com>
Date: Thu, 8 Feb 2018 14:47:32 +0000 (+0100)
Subject: coverity: #1426126
X-Git-Tag: lxc-3.0.0.beta1~39^2~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5b7f756a67b94f846e05210dd1695c1bbabd155e;p=thirdparty%2Flxc.git

coverity: #1426126

Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
---

diff --git a/src/lxc/start.c b/src/lxc/start.c
index 1cbfcae35..6987501e5 100644
--- a/src/lxc/start.c
+++ b/src/lxc/start.c
@@ -1657,7 +1657,10 @@ static int lxc_spawn(struct lxc_handler *handler)
 		DEBUG("Preserved cgroup namespace via fd %d", ret);
 	}
 
-	snprintf(pidstr, 20, "%d", handler->pid);
+	ret = snprintf(pidstr, 20, "%d", handler->pid);
+	if (ret < 0 || ret >= 20)
+		goto out_delete_net;
+
 	if (setenv("LXC_PID", pidstr, 1))
 		SYSERROR("Failed to set environment variable: LXC_PID=%s.", pidstr);