From: Peter Krempa <pkrempa@redhat.com>
Date: Tue, 1 Mar 2022 16:29:04 +0000 (+0100)
Subject: virsh: cmdDesc: Automatically free memory
X-Git-Tag: v8.2.0-rc1~208
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5b811a199d2f09043ae4210b1b56908fc9123285;p=thirdparty%2Flibvirt.git

virsh: cmdDesc: Automatically free memory

Decrease scope of variables and use automatic freeing.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index dcf0f712f6..4d9722f400 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -8333,9 +8333,7 @@ cmdDesc(vshControl *ctl, const vshCmd *cmd)
 
     int state;
     int type;
-    char *desc = NULL;
-    char *desc_edited = NULL;
-    char *tmpstr;
+    g_autofree char *desc = NULL;
     const vshCmdOpt *opt = NULL;
     g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
     bool ret = false;
@@ -8379,6 +8377,8 @@ cmdDesc(vshControl *ctl, const vshCmd *cmd)
 
         if (edit) {
             g_autoptr(vshTempFile) tmp = NULL;
+            g_autofree char *desc_edited = NULL;
+            char *tmpstr;
 
             /* Create and open the temporary file. */
             if (!(tmp = vshEditWriteToTempFile(ctl, desc)))
@@ -8438,8 +8438,6 @@ cmdDesc(vshControl *ctl, const vshCmd *cmd)
 
     ret = true;
  cleanup:
-    VIR_FREE(desc_edited);
-    VIR_FREE(desc);
     return ret;
 }