From: Jim Meyering <meyering@redhat.com>
Date: Thu, 24 May 2012 14:21:34 +0000 (+0200)
Subject: maint: prohibit use of strncpy
X-Git-Tag: v8.18~55
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5b9206c1a851a29d7088bcef000e0c887200c5df;p=thirdparty%2Fcoreutils.git

maint: prohibit use of strncpy

* cfg.mk (sc_prohibit_strncpy): New syntax-check rule.
Exempt pinky.c and who.c, at least for now.
---

diff --git a/cfg.mk b/cfg.mk
index 040d7e17f1..c94109ca37 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -403,6 +403,12 @@ sc_prohibit_strncmp:
 	  { echo '$(ME): use STREQ_LEN or STRPREFIX instead of str''ncmp' \
 		1>&2; exit 1; } || :
 
+# Really.  You don't want to use this function.
+sc_prohibit_strncpy:
+	@prohibit='\<str''ncpy *\('					\
+	halt='do not use str''ncpy, period'				\
+	  $(_sc_search_regexp)
+
 # Enforce recommended preprocessor indentation style.
 sc_preprocessor_indentation:
 	@if cppi --version >/dev/null 2>&1; then			\
@@ -485,3 +491,6 @@ exclude_file_name_regexp--sc_prohibit_test_backticks = \
 # Exempt test.c, since it's nominally shared, and relatively static.
 exclude_file_name_regexp--sc_prohibit_operator_at_end_of_line = \
   ^src/(ptx|test|head)\.c$$
+
+# Exempt pinky and who: their uses of this function appear to be correct.
+exclude_file_name_regexp--sc_prohibit_strncpy = ^src/(pinky|who)\.c$$