From: Viktor Dukhovni <openssl-users@dukhovni.org>
Date: Sat, 18 Jan 2025 07:34:54 +0000 (+1100)
Subject: Check return of OSSL_PROVIDER_do_all to avoid coverity noise
X-Git-Tag: openssl-3.5.0-alpha1~714
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5b94140b52378c1160c1192c662de07b35aef92e;p=thirdparty%2Fopenssl.git

Check return of OSSL_PROVIDER_do_all to avoid coverity noise

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/26462)
---

diff --git a/apps/list.c b/apps/list.c
index c0b0a5a4c43..944722e78f2 100644
--- a/apps/list.c
+++ b/apps/list.c
@@ -789,8 +789,9 @@ static void list_tls_signatures(void)
         OPENSSL_free(builtin_sigalgs);
     }
 
-    /* As built-in providers don't have this capability, never error */
-    OSSL_PROVIDER_do_all(NULL, list_tls_sigalg_caps, &tls_sigalg_listed);
+    if (!OSSL_PROVIDER_do_all(NULL, list_tls_sigalg_caps, &tls_sigalg_listed))
+        BIO_printf(bio_err,
+                   "ERROR: could not list all provider signature algorithms\n");
     if (tls_sigalg_listed < 2)
         BIO_printf(bio_out,
                    "\nNo TLS sig algs registered by currently active providers");