From: Matthijs Mekking <matthijs@isc.org>
Date: Wed, 8 May 2024 07:27:53 +0000 (+0200)
Subject: Do not runtime check uv_tcp_close_reset
X-Git-Tag: v9.20.0~17^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5b94bb21295560aed8b3f1968fbfae261c57aab9;p=thirdparty%2Fbind9.git

Do not runtime check uv_tcp_close_reset

When we reset a TCP connection by sending a RST packet, do not bother
requiring the result is a success code.
---

diff --git a/lib/isc/netmgr/netmgr.c b/lib/isc/netmgr/netmgr.c
index 71a2c5aadc9..a56fef10f74 100644
--- a/lib/isc/netmgr/netmgr.c
+++ b/lib/isc/netmgr/netmgr.c
@@ -1943,7 +1943,12 @@ isc__nmsocket_reset(isc_nmsocket_t *sock) {
 		isc__nmsocket_attach(sock, &(isc_nmsocket_t *){ NULL });
 		int r = uv_tcp_close_reset(&sock->uv_handle.tcp,
 					   reset_shutdown);
-		UV_RUNTIME_CHECK(uv_tcp_close_reset, r);
+		if (r != 0) {
+			isc_log_write(isc_lctx, ISC_LOGCATEGORY_GENERAL,
+				      ISC_LOGMODULE_NETMGR, ISC_LOG_DEBUG(1),
+				      "TCP Reset (RST) failed: %s",
+				      uv_strerror(r));
+		}
 	} else {
 		isc__nmsocket_shutdown(sock);
 	}