From: Mike Yuan <me@yhndnzj.com>
Date: Sat, 7 Sep 2024 00:44:24 +0000 (+0200)
Subject: chattr-util: use BIT_FOREACH where appropriate
X-Git-Tag: v257-rc1~512^2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5bab5e4ac3a90edd7707b479fb0a38999f8bfaac;p=thirdparty%2Fsystemd.git

chattr-util: use BIT_FOREACH where appropriate
---

diff --git a/src/basic/chattr-util.c b/src/basic/chattr-util.c
index 02d2cc2e526..9677e9a35a9 100644
--- a/src/basic/chattr-util.c
+++ b/src/basic/chattr-util.c
@@ -6,6 +6,7 @@
 #include <sys/stat.h>
 #include <linux/fs.h>
 
+#include "bitfield.h"
 #include "chattr-util.h"
 #include "errno-util.h"
 #include "fd-util.h"
@@ -93,11 +94,9 @@ int chattr_full(
          * supported, and we can ignore it too */
 
         unsigned current_attr = old_attr;
-        for (unsigned i = 0; i < sizeof(unsigned) * 8; i++) {
-                unsigned new_one, mask_one = 1u << i;
 
-                if (!FLAGS_SET(mask, mask_one))
-                        continue;
+        BIT_FOREACH(i, mask) {
+                unsigned new_one, mask_one = 1u << i;
 
                 new_one = UPDATE_FLAG(current_attr, mask_one, FLAGS_SET(value, mask_one));
                 if (new_one == current_attr)