From: Miroslav Lichvar <mlichvar@redhat.com>
Date: Wed, 1 Aug 2018 09:59:00 +0000 (+0200)
Subject: util: handle errors in setting of signal handler as fatal
X-Git-Tag: 3.4-pre1~72
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5bb2bf9361b9c445c968873f6891053d53b1efba;p=thirdparty%2Fchrony.git

util: handle errors in setting of signal handler as fatal
---

diff --git a/util.c b/util.c
index 72362026..811914b7 100644
--- a/util.c
+++ b/util.c
@@ -995,7 +995,7 @@ UTI_FdSetCloexec(int fd)
 
 /* ================================================== */
 
-int
+void
 UTI_SetQuitSignalsHandler(void (*handler)(int))
 {
   struct sigaction sa;
@@ -1003,26 +1003,24 @@ UTI_SetQuitSignalsHandler(void (*handler)(int))
   sa.sa_handler = handler;
   sa.sa_flags = SA_RESTART;
   if (sigemptyset(&sa.sa_mask) < 0)
-    return 0;
+    LOG_FATAL("sigemptyset() failed");
 
 #ifdef SIGINT
   if (sigaction(SIGINT, &sa, NULL) < 0)
-    return 0;
+    LOG_FATAL("sigaction(%d) failed", SIGINT);
 #endif
 #ifdef SIGTERM
   if (sigaction(SIGTERM, &sa, NULL) < 0)
-    return 0;
+    LOG_FATAL("sigaction(%d) failed", SIGTERM);
 #endif
 #ifdef SIGQUIT
   if (sigaction(SIGQUIT, &sa, NULL) < 0)
-    return 0;
+    LOG_FATAL("sigaction(%d) failed", SIGQUIT);
 #endif
 #ifdef SIGHUP
   if (sigaction(SIGHUP, &sa, NULL) < 0)
-    return 0;
+    LOG_FATAL("sigaction(%d) failed", SIGHUP);
 #endif
-
-  return 1;
 }
 
 /* ================================================== */
diff --git a/util.h b/util.h
index 40ff7290..96fdc76a 100644
--- a/util.h
+++ b/util.h
@@ -161,7 +161,7 @@ extern Float UTI_FloatHostToNetwork(double x);
 /* Set FD_CLOEXEC on descriptor */
 extern int UTI_FdSetCloexec(int fd);
 
-extern int UTI_SetQuitSignalsHandler(void (*handler)(int));
+extern void UTI_SetQuitSignalsHandler(void (*handler)(int));
 
 /* Get directory (as an allocated string) for a path */
 extern char *UTI_PathToDir(const char *path);