From: Daniel P. Berrange <berrange@redhat.com>
Date: Fri, 29 Jun 2012 15:29:33 +0000 (+0100)
Subject: Remove sub-mounts under /dev when starting an LXC container
X-Git-Tag: v0.9.13~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5bb83236c9c9b22afb263dc2a5084b0f922e44bb;p=thirdparty%2Flibvirt.git

Remove sub-mounts under /dev when starting an LXC container

Since we are mounting a new /dev in the container, we must
remove any sub-mounts like /dev/shm, /dev/mqueue, etc,
otherwise they'll be recorded in /proc/mounts, but not be
accessible to applications.
---

diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c
index 071d8d1bf0..910e82b4a5 100644
--- a/src/lxc/lxc_container.c
+++ b/src/lxc/lxc_container.c
@@ -1416,10 +1416,11 @@ static int lxcContainerSetupPivotRoot(virDomainDefPtr vmDef,
     if (lxcContainerPivotRoot(root) < 0)
         goto cleanup;
 
-    /* Gets rid of any existing stuff under /proc, since we need new
-     * namespace aware versions of those. We must do /proc second
-     * otherwise we won't find /proc/mounts :-) */
+    /* Gets rid of any existing stuff under /proc, /sys & /tmp
+     * We need new namespace aware versions of those. We must
+     * do /proc last otherwise we won't find /proc/mounts :-) */
     if (lxcContainerUnmountSubtree("/sys", false) < 0 ||
+        lxcContainerUnmountSubtree("/dev", false) < 0 ||
         lxcContainerUnmountSubtree("/proc", false) < 0)
         goto cleanup;