From: zach%zachlipton.com <>
Date: Mon, 28 Jan 2002 02:59:38 +0000 (+0000)
Subject: Fix for bug 121735: Perl warning running checksetup.pl if a module has a
X-Git-Tag: bugzilla-2.16rc1~262
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5bbb0f101966acb382e643303129a9057ff49987;p=thirdparty%2Fbugzilla.git

Fix for bug 121735: Perl warning running checksetup.pl if a module has a
non-numeric version number. Patch sets checksetup.pl to use a string
compare instead of a numeric one.

Patch by Dave Miller. r1=Bradley Baetz and r2=Gerv
---

diff --git a/checksetup.pl b/checksetup.pl
index e5864921bc..d793879ff7 100755
--- a/checksetup.pl
+++ b/checksetup.pl
@@ -167,10 +167,10 @@ sub have_vers {
   $vnum = ${"${pkg}::VERSION"} || ${"${pkg}::Version"} || 0;
   $vnum = -1 if $@;
 
-  if ($vnum < 0) {
+  if ($vnum eq "-1") { # string compare just in case it's non-numeric
     $vstr = "not found";
   }
-  elsif ($vnum > 0) {
+  elsif (vers_cmp($vnum,"0") > -1) {
     $vstr = "found v$vnum";
   }
   else {