From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Date: Sat, 11 Mar 2017 21:07:21 +0000 (+0000)
Subject: Add missing break for the DRM ioctl operations that do not have any args
X-Git-Tag: svn/VALGRIND_3_13_0~158
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5bc11df85caefb61fc3fa44aca89b53421c75d2a;p=thirdparty%2Fvalgrind.git

Add missing break for the DRM ioctl operations that do not have any args
Due to this missing break, the code was falling through to
the case VKI_SNDRV_CTL_IOCTL_PVERSION:
and was then setting some bytes as defined at (whatever address is in) ARG3.

Patch and analysis by Daniel Glöckner



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@16266
---

diff --git a/coregrind/m_syswrap/syswrap-linux.c b/coregrind/m_syswrap/syswrap-linux.c
index 02fb127c71..bd6c3f2cca 100644
--- a/coregrind/m_syswrap/syswrap-linux.c
+++ b/coregrind/m_syswrap/syswrap-linux.c
@@ -9520,6 +9520,8 @@ POST(sys_ioctl)
    case VKI_SNDRV_TIMER_IOCTL_STOP:
    case VKI_SNDRV_TIMER_IOCTL_CONTINUE:
    case VKI_SNDRV_TIMER_IOCTL_PAUSE:
+      break;
+
    case VKI_SNDRV_CTL_IOCTL_PVERSION: {
       POST_MEM_WRITE( (Addr)ARG3, sizeof(int) );
       break;