From: Tomas Mraz <tomas@openssl.org>
Date: Fri, 20 Sep 2024 12:42:52 +0000 (+0200)
Subject: cmp_vfy_test.c: Avoid NULL pointer dereference
X-Git-Tag: openssl-3.5.0-alpha1~1043
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5bc13d5d8c8b65b09031baa954a245c889c0b19a;p=thirdparty%2Fopenssl.git

cmp_vfy_test.c: Avoid NULL pointer dereference

Fixes Coverity 1619463

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25503)
---

diff --git a/test/cmp_vfy_test.c b/test/cmp_vfy_test.c
index 4ce309992fc..114b1044975 100644
--- a/test/cmp_vfy_test.c
+++ b/test/cmp_vfy_test.c
@@ -336,8 +336,9 @@ static int test_validate_msg_signature_sender_cert_extracert(void)
             || !add_trusted(fixture->cmp_ctx, instaca_cert)) {
         tear_down(fixture);
         fixture = NULL;
+    } else {
+        fixture->cert = sk_X509_value(fixture->msg->extraCerts, 1); /* Insta CA */
     }
-    fixture->cert = sk_X509_value(fixture->msg->extraCerts, 1); /* Insta CA */
     EXECUTE_TEST(execute_validate_msg_test, tear_down);
     return result;
 }