From: Julian Seward <jseward@acm.org>
Date: Thu, 15 Jul 2004 18:18:47 +0000 (+0000)
Subject: setFlags_DSTus_DST1: generate well-typed IR for Mux10 arms
X-Git-Tag: svn/VALGRIND_3_0_1^2~1245
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5bca5080f6e03cafe8d4b58fcff4c612d540af57;p=thirdparty%2Fvalgrind.git

setFlags_DSTus_DST1: generate well-typed IR for Mux10 arms


git-svn-id: svn://svn.valgrind.org/vex/trunk@89
---

diff --git a/VEX/priv/guest-x86/x86toIR.c b/VEX/priv/guest-x86/x86toIR.c
index 64e616786e..d9f4ec5bb7 100644
--- a/VEX/priv/guest-x86/x86toIR.c
+++ b/VEX/priv/guest-x86/x86toIR.c
@@ -422,6 +422,16 @@ static void setFlags_SRC_DST1 ( IROp    op8,
    result except shifted one bit less.  And then only when the guard
    says we can. */
 
+static IRExpr* widenUTo32 ( IRExpr* e )
+{
+   switch (typeOfIRExpr(irbb->tyenv,e)) {
+      case Ity_I32: return e;
+      case Ity_I16: return unop(Iop_16Uto32,e);
+      case Ity_I8:  return unop(Iop_8Uto32,e);
+      default: vpanic("widenUto32");
+   }
+}
+
 static void setFlags_DSTus_DST1 ( IROp    op8,
                                   IRTemp  dstUS,
                                   IRTemp  dst1,
@@ -448,11 +458,11 @@ static void setFlags_DSTus_DST1 ( IROp    op8,
                                    IRExpr_Get(OFFB_CC_OP,Ity_I32))) );
    stmt( IRStmt_Put( OFFB_CC_SRC, 
                      IRExpr_Mux10( mkexpr(guard),
-                                   mkexpr(dstUS),
+                                   widenUTo32(mkexpr(dstUS)),
                                    IRExpr_Get(OFFB_CC_SRC,Ity_I32))) );
    stmt( IRStmt_Put( OFFB_CC_DST,
                      IRExpr_Mux10( mkexpr(guard),
-                                   mkexpr(dst1),
+                                   widenUTo32(mkexpr(dst1)),
                                    IRExpr_Get(OFFB_CC_DST,Ity_I32))) );
 }