From: Stephen Hemminger Date: Sun, 29 Nov 2020 17:32:50 +0000 (-0800) Subject: bridge: fix string length warning X-Git-Tag: v5.10.0~6^2~4 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5bdc4e9151a19f0bc8c851cfcca75363abb19fde;p=thirdparty%2Fiproute2.git bridge: fix string length warning Gcc-10 complains about possible string length overflow. This can't happen Ethernet address format is always limited to 18 characters or less. Just resize the temp buffer. Fixes: 70dfb0b8836d ("iplink: bridge: export bridge_id and designated_root") Cc: nikolay@cumulusnetworks.com Signed-off-by: Stephen Hemminger --- diff --git a/ip/iplink_bridge.c b/ip/iplink_bridge.c index 3e81aa059..d12fd0558 100644 --- a/ip/iplink_bridge.c +++ b/ip/iplink_bridge.c @@ -74,7 +74,7 @@ static void explain(void) void br_dump_bridge_id(const struct ifla_bridge_id *id, char *buf, size_t len) { - char eaddr[32]; + char eaddr[18]; ether_ntoa_r((const struct ether_addr *)id->addr, eaddr); snprintf(buf, len, "%.2x%.2x.%s", id->prio[0], id->prio[1], eaddr);