From: mkanat%bugzilla.org <>
Date: Wed, 26 Nov 2008 00:52:34 +0000 (+0000)
Subject: Bug 466406: Passing an empty comment to Bug.add_comment fails silently
X-Git-Tag: bugzilla-3.3.1~65
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5bf043eea026fbc8f0834736f213d946599991ed;p=thirdparty%2Fbugzilla.git

Bug 466406: Passing an empty comment to Bug.add_comment fails silently
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=mkanat
---

diff --git a/Bugzilla/WebService/Bug.pm b/Bugzilla/WebService/Bug.pm
index b6411968c1..d60f5015bf 100755
--- a/Bugzilla/WebService/Bug.pm
+++ b/Bugzilla/WebService/Bug.pm
@@ -29,6 +29,7 @@ use Bugzilla::Field;
 use Bugzilla::WebService::Constants;
 use Bugzilla::Bug;
 use Bugzilla::BugMail;
+use Bugzilla::Util qw(trim);
 
 #############
 # Constants #
@@ -233,7 +234,7 @@ sub add_comment {
     defined $params->{id} 
         || ThrowCodeError('param_required', { param => 'id' }); 
     my $comment = $params->{comment}; 
-    defined $comment
+    (defined $comment && trim($comment) ne '')
         || ThrowCodeError('param_required', { param => 'comment' });
     
     my $bug = Bugzilla::Bug->check($params->{id});
@@ -655,6 +656,8 @@ This allows you to add a comment to a bug in Bugzilla.
 comment to.
 
 =item C<comment> (string) B<Required> - The comment to append to the bug.
+If this is empty or all whitespace, an error will be thrown saying that
+you did not set the C<comment> parameter.
 
 =item C<private> (boolean) - If set to true, the comment is private, otherwise
 it is assumed to be public.