From: Francesco Chemolli <5175948+kinkie@users.noreply.github.com>
Date: Wed, 1 May 2024 07:31:25 +0000 (+0000)
Subject: Optimization: DelayUser::Id constructor copied user pointers (#1800)
X-Git-Tag: SQUID_7_0_1~133
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5bff6f65e4362451ba85a6fd04932f44a6263759;p=thirdparty%2Fsquid.git

Optimization: DelayUser::Id constructor copied user pointers (#1800)

Detected by Coverity. CID 1529593: Unnecessary object copies can affect
performance (COPY_INSTEAD_OF_MOVE).
---

diff --git a/src/DelayUser.cc b/src/DelayUser.cc
index 40892340aa..b6d2ca209b 100644
--- a/src/DelayUser.cc
+++ b/src/DelayUser.cc
@@ -139,7 +139,7 @@ DelayUserBucket::stats (StoreEntry *entry) const
     theBucket.stats(entry);
 }
 
-DelayUser::Id::Id(DelayUser::Pointer aDelayUser, Auth::User::Pointer aUser) : theUser(aDelayUser)
+DelayUser::Id::Id(const DelayUser::Pointer &aDelayUser, const Auth::User::Pointer &aUser) : theUser(aDelayUser)
 {
     theBucket = new DelayUserBucket(aUser);
     DelayUserBucket::Pointer const *existing = theUser->buckets.find(theBucket, DelayUserCmp);
diff --git a/src/DelayUser.h b/src/DelayUser.h
index c6e4d0db33..ad52a942a9 100644
--- a/src/DelayUser.h
+++ b/src/DelayUser.h
@@ -60,7 +60,7 @@ private:
         MEMPROXY_CLASS(DelayUser::Id);
 
     public:
-        Id(RefCount<DelayUser>, Auth::User::Pointer);
+        Id(const DelayUser::Pointer &, const Auth::User::Pointer &);
         ~Id() override;
         int bytesWanted (int min, int max) const override;
         void bytesIn(int qty) override;