From: Diego Fronza <diego@isc.org>
Date: Wed, 25 Nov 2020 19:39:19 +0000 (-0300)
Subject: Silence coverity warnings in query.c
X-Git-Tag: v9.16.10~8^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5c28451949d9927af282285051e3346fb34813d0;p=thirdparty%2Fbind9.git

Silence coverity warnings in query.c

Return value of dns_db_getservestalerefresh() and
dns_db_getservestalettl() functions were previously unhandled.

This commit purposefully ignore those return values since there is
no side effect if those results are != ISC_R_SUCCESS, it also supress
Coverity warnings.
---

diff --git a/lib/ns/query.c b/lib/ns/query.c
index 159122488d9..59078f3edad 100644
--- a/lib/ns/query.c
+++ b/lib/ns/query.c
@@ -5577,9 +5577,9 @@ query_lookup(query_ctx_t *qctx) {
 		dboptions |= DNS_DBFIND_COVERINGNSEC;
 	}
 
-	dns_db_getservestalerefresh(qctx->client->view->cachedb,
-				    &stale_refresh);
-	dns_db_getservestalettl(qctx->client->view->cachedb, &stale_ttl);
+	(void)dns_db_getservestalerefresh(qctx->client->view->cachedb,
+					  &stale_refresh);
+	(void)dns_db_getservestalettl(qctx->client->view->cachedb, &stale_ttl);
 	if (stale_refresh > 0) {
 		if (qctx->client->view->staleanswersok == dns_stale_answer_yes)
 		{