From: Volker Lendecke <vl@samba.org>
Date: Mon, 15 Apr 2013 20:11:44 +0000 (+0200)
Subject: talloc: Avoid some "else" by doing early returns
X-Git-Tag: samba-4.0.26~44
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5c2eadec328d966d33be806dea8885ff44b24487;p=thirdparty%2Fsamba.git

talloc: Avoid some "else" by doing early returns

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit ccf33dd0547f32104041c8611626f3e02e22cbe9)
---

diff --git a/lib/talloc/talloc.c b/lib/talloc/talloc.c
index d0c81d3d43a..011e8f33436 100644
--- a/lib/talloc/talloc.c
+++ b/lib/talloc/talloc.c
@@ -935,12 +935,16 @@ static inline int _talloc_free_internal(void *ptr, const char *location)
 			TC_INVALIDATE_FULL_CHUNK(tc);
 			free(tc);
 		}
-	} else if (tc->flags & TALLOC_FLAG_POOLMEM) {
+		return 0;
+	}
+
+	if (tc->flags & TALLOC_FLAG_POOLMEM) {
 		_talloc_free_poolmem(tc, location);
-	} else {
-		TC_INVALIDATE_FULL_CHUNK(tc);
-		free(tc);
+		return 0;
 	}
+
+	TC_INVALIDATE_FULL_CHUNK(tc);
+	free(tc);
 	return 0;
 }