From: Pick <pickchen@tencent.com>
Date: Wed, 1 Jul 2020 19:39:13 +0000 (+0800)
Subject: refactor(computed): deprecated computedRunners (#1458)
X-Git-Tag: v3.0.0-beta.18~11
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5c490f1c45416fbaff97024226ca423cd2c67ed0;p=thirdparty%2Fvuejs%2Fcore.git

refactor(computed): deprecated computedRunners (#1458)
---

diff --git a/packages/reactivity/src/computed.ts b/packages/reactivity/src/computed.ts
index d6f89fe284..611ecaefb5 100644
--- a/packages/reactivity/src/computed.ts
+++ b/packages/reactivity/src/computed.ts
@@ -48,7 +48,6 @@ export function computed<T>(
   const runner = effect(getter, {
     lazy: true,
     // mark effect as computed so that it gets priority during trigger
-    computed: true,
     scheduler: () => {
       if (!dirty) {
         dirty = true
diff --git a/packages/reactivity/src/effect.ts b/packages/reactivity/src/effect.ts
index c6187d296e..98aff15ddb 100644
--- a/packages/reactivity/src/effect.ts
+++ b/packages/reactivity/src/effect.ts
@@ -177,16 +177,11 @@ export function trigger(
   }
 
   const effects = new Set<ReactiveEffect>()
-  const computedRunners = new Set<ReactiveEffect>()
   const add = (effectsToAdd: Set<ReactiveEffect> | undefined) => {
     if (effectsToAdd) {
       effectsToAdd.forEach(effect => {
         if (effect !== activeEffect || !shouldTrack) {
-          if (effect.options.computed) {
-            computedRunners.add(effect)
-          } else {
-            effects.add(effect)
-          }
+          effects.add(effect)
         } else {
           // the effect mutated its own dependency during its execution.
           // this can be caused by operations like foo.value++
@@ -245,8 +240,5 @@ export function trigger(
     }
   }
 
-  // Important: computed effects must be run first so that computed getters
-  // can be invalidated before any normal effects that depend on them are run.
-  computedRunners.forEach(run)
   effects.forEach(run)
 }