From: Christopher Faulet <cfaulet@haproxy.com>
Date: Mon, 15 Dec 2025 06:56:52 +0000 (+0100)
Subject: CLEANUP: backend: Remove useless test on server's xprt
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5c5914c32edeeb2bc91e9ea61124b3089886239c;p=thirdparty%2Fhaproxy.git

CLEANUP: backend: Remove useless test on server's xprt

The server's xprt is always defined and cannot be NULL. So there is no
reason to test it. It could lead to wrong assumptions later in the code.

This patch should fix a Coverity report from #3213.
---

diff --git a/src/backend.c b/src/backend.c
index 9722b71b9..34ec96711 100644
--- a/src/backend.c
+++ b/src/backend.c
@@ -2042,7 +2042,7 @@ int connect_server(struct stream *s)
 			struct ist sni = IST_NULL;
 
 			/* Set socket SNI */
-			if (srv->xprt && srv->xprt->get_ssl_sock_ctx && srv->ssl_ctx.sni) {
+			if (srv->xprt->get_ssl_sock_ctx && srv->ssl_ctx.sni) {
 				sni_smp = sample_fetch_as_type(s->be, s->sess, s,
 							       SMP_OPT_DIR_REQ | SMP_OPT_FINAL,
 							       srv->ssl_ctx.sni, SMP_T_STR);