From: Johannes Berg <johannes@sipsolutions.net>
Date: Thu, 2 Jul 2009 13:46:41 +0000 (+0200)
Subject: cfg80211: fix refcount leak
X-Git-Tag: v2.6.30.4~62
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5c8affc6e16f6bad03b5c23d25b2c774b817160a;p=thirdparty%2Fkernel%2Fstable.git

cfg80211: fix refcount leak

commit 2dce4c2b5f0b43bd25bf9ea6ded06b7f8a54c91f upstream.

The code in cfg80211's cfg80211_bss_update erroneously
grabs a reference to the BSS, which means that it will
never be freed.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/net/wireless/scan.c b/net/wireless/scan.c
index 1f260c40b6ca4..bc7f788298608 100644
--- a/net/wireless/scan.c
+++ b/net/wireless/scan.c
@@ -365,7 +365,6 @@ cfg80211_bss_update(struct cfg80211_registered_device *dev,
 	found = rb_find_bss(dev, res);
 
 	if (found) {
-		kref_get(&found->ref);
 		found->pub.beacon_interval = res->pub.beacon_interval;
 		found->pub.tsf = res->pub.tsf;
 		found->pub.signal = res->pub.signal;