From: Marek Schimara <Marek.Schimara@bull.net>
Date: Thu, 16 Jun 2016 07:06:45 +0000 (+0200)
Subject: src/rrd_cgi.c: fix Coverity CID#13656 Resource leak
X-Git-Tag: v1.7.0~42^2~40
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5c8f8f94559584eff01662a6fb0180468d838a29;p=thirdparty%2Frrdtool-1.x.git

src/rrd_cgi.c: fix Coverity CID#13656 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html
---

diff --git a/src/rrd_cgi.c b/src/rrd_cgi.c
index 770d9ebf..8917f698 100644
--- a/src/rrd_cgi.c
+++ b/src/rrd_cgi.c
@@ -1449,8 +1449,10 @@ s_var   **rrdcgiReadVariables(
     }
 
     len = (numargs + 1) * sizeof(s_var *);
-    if ((result = (s_var **) malloc(len)) == NULL)
+    if ((result = (s_var **) malloc(len)) == NULL) {
+        free(line);
         return NULL;
+    }
     memset(result, 0, len);
 
     cp = line;
@@ -1514,6 +1516,8 @@ s_var   **rrdcgiReadVariables(
         }
         cp = ++ip;
     }
+
+    free(line);
     return result;
 }