From: Peter Krempa Date: Wed, 16 Feb 2022 15:24:01 +0000 (+0100) Subject: virDriverFeatureIsGlobal: Handle VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER X-Git-Tag: v8.1.0-rc1~33 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5c953401005c2ffaa48aa394c98e01ad680596f6;p=thirdparty%2Flibvirt.git virDriverFeatureIsGlobal: Handle VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER The fix was on RPC level so everything should advertise it. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko Reviewed-by: Andrea Bolognani --- diff --git a/src/driver.c b/src/driver.c index d070861cfd..bcf5db5998 100644 --- a/src/driver.c +++ b/src/driver.c @@ -357,10 +357,14 @@ virDriverFeatureIsGlobal(virDrvFeature feat, * At this point everything supports them and thus also drivers need to * always advertise this feature */ case VIR_DRV_FEATURE_TYPED_PARAM_STRING: + /* Feature flag exposes that the accidental switching of order of arguments + * in the public API trampoline virNetworkUpdate is known. Updated clients + * thus use the correct ordering with an updated server. All drivers must + * signal support for this feature. */ + case VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER: *supported = 1; return true; - case VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER: case VIR_DRV_FEATURE_FD_PASSING: case VIR_DRV_FEATURE_MIGRATION_V2: case VIR_DRV_FEATURE_MIGRATION_V3: