From: Michal Privoznik <mprivozn@redhat.com>
Date: Sat, 5 Oct 2024 21:50:25 +0000 (+0200)
Subject: vbox: Report an error when VBox CAPI initialization fails
X-Git-Tag: v11.1.0-rc1~150
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5ca7f27f754cc4cdb38f0a1427b3459d88383f75;p=thirdparty%2Flibvirt.git

vbox: Report an error when VBox CAPI initialization fails

If initialization of VBOX fails inside of _pfnInitialize an
negative value is returned to signal an error condition to a
caller but no error message is printed out. Reporting an error
may shed more light into why VBOX failed to initialize.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
---

diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c
index 908625e702..0059a9ee3d 100644
--- a/src/vbox/vbox_tmpl.c
+++ b/src/vbox/vbox_tmpl.c
@@ -429,13 +429,18 @@ static int _pfnInitialize(struct _vboxDriver *driver)
 {
     nsresult rc;
 
-    if (!(driver->pFuncs = g_pfnGetFunctions(VBOX_XPCOMC_VERSION)))
+    if (!(driver->pFuncs = g_pfnGetFunctions(VBOX_XPCOMC_VERSION))) {
+        virReportError(VIR_ERR_OPERATION_FAILED, "%s",
+                       _("Unable to get pointer to VirtualBox vtable"));
         return -1;
+    }
 
     rc = driver->pFuncs->pfnClientInitialize(IVIRTUALBOXCLIENT_IID_STR,
                                              &driver->vboxClient);
 
     if (NS_FAILED(rc)) {
+        virReportError(VIR_ERR_OPERATION_FAILED, "%s",
+                       _("Unable to initialize VirtualBox C API client"));
         return -1;
     } else {
         driver->vboxClient->vtbl->GetVirtualBox(driver->vboxClient, &driver->vboxObj);