From: Alan T. DeKok <aland@freeradius.org>
Date: Sun, 2 Mar 2025 14:02:44 +0000 (-0500)
Subject: just encode everything which matches the cursor
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5ca9913f6b1bf7431ecc48398937520dbef0ea46;p=thirdparty%2Ffreeradius-server.git

just encode everything which matches the cursor

the iterator is responsible for doing the right thing.

The depth checks don't work with groups which have refs
---

diff --git a/src/lib/util/encode.c b/src/lib/util/encode.c
index 9a776f1bccb..a952b9469bc 100644
--- a/src/lib/util/encode.c
+++ b/src/lib/util/encode.c
@@ -74,7 +74,6 @@ ssize_t fr_pair_cursor_to_network(fr_dbuff_t *dbuff,
 {
 	fr_dbuff_t		work_dbuff = FR_DBUFF(dbuff);
 	fr_pair_t const		*vp;
-	fr_dict_attr_t const	*da = da_stack->da[depth];
 	ssize_t			len;
 
 	while (true) {
@@ -95,13 +94,6 @@ ssize_t fr_pair_cursor_to_network(fr_dbuff_t *dbuff,
 		if (!vp) break;
 
 		fr_proto_da_stack_build(da_stack, vp->da);
-
-		/*
-		 *	We can encode multiple children, if after
-		 *	rebuilding the DA Stack, the attribute at this
-		 *	depth is the same.
-		 */
-		if ((da != da_stack->da[depth]) || (da_stack->depth < da->depth)) break;
 	}
 
 	FR_PROTO_HEX_DUMP(fr_dbuff_start(&work_dbuff), fr_dbuff_used(&work_dbuff), "Done cursor");