From: lpsolit%gmail.com <>
Date: Mon, 3 Dec 2007 05:19:45 +0000 (+0000)
Subject: Bug 400243: "votes:n" quicksearch should be "at least n votes", not "more than n... 
X-Git-Tag: bugzilla-3.0.3~9
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5cc0a3b41f77a4fc229d168e69c8c6485d2bc468;p=thirdparty%2Fbugzilla.git

Bug 400243: "votes:n" quicksearch should be "at least n votes", not "more than n votes" - Patch by Frédéric Buclin <LpSolit@gmail.com> r=justdave a=LpSolit
---

diff --git a/Bugzilla/Search/Quicksearch.pm b/Bugzilla/Search/Quicksearch.pm
index 3328e1f559..151d6f81a7 100644
--- a/Bugzilla/Search/Quicksearch.pm
+++ b/Bugzilla/Search/Quicksearch.pm
@@ -267,7 +267,7 @@ sub quicksearch {
                 foreach my $or_operand (split(/\|/, $qsword)) {
                     if ($or_operand =~ /^votes:([0-9]+)$/) {
                         # votes:xx ("at least xx votes")
-                        addChart('votes', 'greaterthan', $1, $negate);
+                        addChart('votes', 'greaterthan', $1 - 1, $negate);
                     }
                     elsif ($or_operand =~ /^([^:]+):([^:]+)$/) {
                         # generic field1,field2,field3:value1,value2 notation
diff --git a/template/en/default/pages/quicksearchhack.html.tmpl b/template/en/default/pages/quicksearchhack.html.tmpl
index 47a0eacd3b..821f3ad5b0 100644
--- a/template/en/default/pages/quicksearchhack.html.tmpl
+++ b/template/en/default/pages/quicksearchhack.html.tmpl
@@ -264,7 +264,17 @@
   <td><tt>attachmimetype</tt></td>
   <td>Attachment mime-type <i>(&ldquo;attachments.mimetype&rdquo;)</i></td>
 </tr>
-
+<tr>
+  <td>&nbsp;</td>
+  <td>&nbsp;</td>
+  <td><tt>votes</tt></td>
+  <td>&nbsp;</td>
+  <td>
+    Number of votes<br>
+    (votes:<i>N</i> and votes&gt;=<i>N</i> mean "at least N votes",
+    votes&gt;<i>N</i> means "more than N votes")
+  </td>
+</tr>
 </table>
 
 <p>
@@ -301,19 +311,6 @@
   <td><b>:</b><i>area</i></td>
   <td><b>product,component:</b><i>area</i></td>
 </tr>
-<!--
-<tr>
-  <td><tt>:browser</tt></td>
-  <td><i>[% terms.bugs %] in the Browser product</i></td>
-</tr>
- <td><tt>:mail</tt></td>
-  <td><i>[% terms.bugs %] in the MailNews product</td>
-</tr>
-<tr>
-  <td><tt>:xbl</tt></td>
-  <td><i>[% terms.bugs %] in the XBL component</i></td>
-</tr>
-  -->
 <tr>
   <td><i>sev</i></td>
   <td><b>severity:</b><i>sev</i></td>
@@ -342,30 +339,10 @@
   <td><b>@</b><i>assignee</i></td>
   <td><b>assignedto:</b><i>assignee</i></td>
 </tr>
-<!--
-<tr>
-  <td><tt>@nobody</tt></td>
-  <td><i>assigneeless [% terms.bugs %]</i></td>
-</tr>
-<tr>
-  <td><tt>@mozilla.org</tt></td>
-  <td><i>[% terms.bugs %] assigned to mozilla.org members</i></td>
-</tr>
-  -->
 <tr>
   <td><b>!</b><i>keyword</i></td>
   <td><b>keywords:</b><i>keyword</i></td>
 </tr>
-<!--
-<tr>
-  <td><tt>!crash</tt></td>
-  <td><i>crasher [% terms.bugs %]</i></td>
-</tr>
-<tr>
-  <td><tt>!helpwanted</tt></td>
-  <td><i>[% terms.bugs %] waiting for your help</i></td>
-</tr>
-  -->
 </table>
 
 <p>