From: Michal Privoznik <mprivozn@redhat.com>
Date: Thu, 3 Jun 2021 12:33:00 +0000 (+0200)
Subject: virSecurityDACSetOwnershipInternal: Drop dead code
X-Git-Tag: v7.5.0-rc1~54
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5cfb3369b18a7964b43114e60bc9ae5d5166c593;p=thirdparty%2Flibvirt.git

virSecurityDACSetOwnershipInternal: Drop dead code

The virSecurityDACSetOwnershipInternal() function accepts two
arguments (among others): @path and @src. The idea being that in
some cases @path is NULL and @src is not and then @path is filled
from @src->path. However, this is done in both callers already
(because of seclabel remembering/recall). Therefore, this code in
virSecurityDACSetOwnershipInternal() is dead, effectively.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/security/security_dac.c b/src/security/security_dac.c
index b6323a7df1..e2a6461375 100644
--- a/src/security/security_dac.c
+++ b/src/security/security_dac.c
@@ -688,15 +688,8 @@ virSecurityDACSetOwnershipInternal(const virSecurityDACData *priv,
     } else {
         struct stat sb;
 
-        if (!path) {
-            if (!src || !src->path)
-                return 0;
-
-            if (!virStorageSourceIsLocalStorage(src))
-                return 0;
-
-            path = src->path;
-        }
+        if (!path)
+            return 0;
 
         if (stat(path, &sb) < 0) {
             virReportSystemError(errno, _("unable to stat: %s"), path);