From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Fri, 29 Oct 2021 15:17:55 +0000 (+0200)
Subject: dnsdist: Fix missing 'continue's when cleaning the connections cleaning code
X-Git-Tag: dnsdist-1.7.0-beta1~5^2~8
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5d013c733b024bc21db8a6f020be0d238610948b;p=thirdparty%2Fpdns.git

dnsdist: Fix missing 'continue's when cleaning the connections cleaning code
---

diff --git a/pdns/dnsdistdist/dnsdist-nghttp2.cc b/pdns/dnsdistdist/dnsdist-nghttp2.cc
index e7ac86f64c..b739ac3c05 100644
--- a/pdns/dnsdistdist/dnsdist-nghttp2.cc
+++ b/pdns/dnsdistdist/dnsdist-nghttp2.cc
@@ -932,6 +932,7 @@ void DownstreamDoHConnectionsManager::cleanupClosedConnections(struct timeval no
 
       if ((*connIt)->isUsable()) {
         ++connIt;
+        continue;
       }
 
       connIt = dsIt->second.erase(connIt);
diff --git a/pdns/dnsdistdist/dnsdist-tcp-downstream.cc b/pdns/dnsdistdist/dnsdist-tcp-downstream.cc
index acf55d7249..1a76842dc6 100644
--- a/pdns/dnsdistdist/dnsdist-tcp-downstream.cc
+++ b/pdns/dnsdistdist/dnsdist-tcp-downstream.cc
@@ -852,6 +852,7 @@ void DownstreamConnectionsManager::cleanupClosedTCPConnections(struct timeval no
 
       if ((*connIt)->isUsable()) {
         ++connIt;
+        continue;
       }
 
       connIt = dsIt->second.erase(connIt);