From: Phil Carmody <phil@dovecot.fi>
Date: Tue, 25 Nov 2014 01:45:35 +0000 (+0200)
Subject: lib: test-array - fix off-by-one in test_reverse
X-Git-Tag: 2.2.16.rc1~192
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5d017bb2f0820b8a8d6b4e965435b78860dc9559;p=thirdparty%2Fdovecot%2Fcore.git

lib: test-array - fix off-by-one in test_reverse
i is not used as an index, but as a count. Therefore, it can attain the
array size in the loop without causing any buffer overflows.

Signed-off-by: Phil Carmody <phil@dovecot.fi>
---

diff --git a/src/lib/test-array.c b/src/lib/test-array.c
index 2c8a7a9997..fb052795d8 100644
--- a/src/lib/test-array.c
+++ b/src/lib/test-array.c
@@ -41,7 +41,7 @@ static void test_array_reverse(void)
 
 	test_begin("array reverse");
 	t_array_init(&intarr, 5);
-	for (i = 0; i < N_ELEMENTS(input); i++) {
+	for (i = 0; i <= N_ELEMENTS(input); i++) {
 		array_clear(&intarr);
 		array_append(&intarr, input, i);
 		array_reverse(&intarr);