From: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Date: Wed, 20 Jul 2022 17:06:02 +0000 (-0600)
Subject: abstraction-cpu: fix resource leak in read_setting()
X-Git-Tag: v3.0~18
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5d0fd92106fd024fde6b56e5a5289941ab159499;p=thirdparty%2Flibcgroup.git

abstraction-cpu: fix resource leak in read_setting()

Fix a resource leak, reported by Coverity tool:

CID 258274 (#1 of 1): Resource leak (RESOURCE_LEAK)6. leaked_storage:
Variable handle going out of scope leaks the storage it points to

In read_setting(), currently, we goto end label, on the failure of
strdup() before closing the handle, leaking the resource. Fix it by
removing the goto, that allows the code flow to close the handle and
execute the code under the end label.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
---

diff --git a/src/abstraction-cpu.c b/src/abstraction-cpu.c
index a7ed6843..5a56bc07 100644
--- a/src/abstraction-cpu.c
+++ b/src/abstraction-cpu.c
@@ -40,10 +40,8 @@ static int read_setting(const char * const cgroup_name, const char * const contr
 		goto end;
 
 	*value = strdup(tmp_line);
-	if ((*value) == NULL) {
+	if ((*value) == NULL)
 		ret = ECGOTHER;
-		goto end;
-	}
 
 read_end:
 	cgroup_read_value_end(&handle);