From: Stefan Metzmacher <metze@samba.org>
Date: Mon, 4 Mar 2024 18:31:33 +0000 (+0100)
Subject: auth/gensec: remove useless client_use_spnego_principal usage
X-Git-Tag: tdb-1.4.11~934
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5d350c1ecd18d2d691aeb559b387c8e3c811cb81;p=thirdparty%2Fsamba.git

auth/gensec: remove useless client_use_spnego_principal usage

It's off by default and all sane servers use
not_defined_in_RFC4178@please_ignore anyway.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/auth/gensec/spnego.c b/auth/gensec/spnego.c
index fcb5a06439e..717f643957a 100644
--- a/auth/gensec/spnego.c
+++ b/auth/gensec/spnego.c
@@ -503,18 +503,8 @@ static NTSTATUS gensec_spnego_client_negTokenInit_start(
 					TALLOC_CTX *in_mem_ctx,
 					DATA_BLOB *in_next)
 {
-	const char *tp = NULL;
-
 	/* The server offers a list of mechanisms */
 
-	tp = spnego_in->negTokenInit.targetPrincipal;
-	if (tp != NULL && strcmp(tp, ADS_IGNORE_PRINCIPAL) != 0) {
-		DBG_INFO("Server claims it's principal name is %s\n", tp);
-		if (lpcfg_client_use_spnego_principal(gensec_security->settings->lp_ctx)) {
-			gensec_set_target_principal(gensec_security, tp);
-		}
-	}
-
 	n->mech_idx = 0;
 
 	/* Do not use server mech list as it isn't protected. Instead, get all