From: Marcin Siodelski <marcin@isc.org>
Date: Tue, 26 Mar 2019 06:49:11 +0000 (+0100)
Subject: [#103,!277] Address two minor review comments.
X-Git-Tag: Kea-1.6.0-beta~311
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5d53f731a1a780253dd9bd4c45d0578b73733085;p=thirdparty%2Fkea.git

[#103,!277] Address two minor review comments.
---

diff --git a/src/bin/dhcp4/ctrl_dhcp4_srv.cc b/src/bin/dhcp4/ctrl_dhcp4_srv.cc
index e7e990325b..3aa2e2d14c 100644
--- a/src/bin/dhcp4/ctrl_dhcp4_srv.cc
+++ b/src/bin/dhcp4/ctrl_dhcp4_srv.cc
@@ -680,12 +680,11 @@ ControlledDhcpv4Srv::processConfig(isc::data::ConstElementPtr config) {
         // Only schedule the CB fetch timer if the fetch wait time is greater
         // than 0.
         if (fetch_time > 0) {
-            // The port number is 0 only when we run unit tests. In such case, we
-            // want to use milliseconds unit for the specified interval. Otherwise,
-            // we use seconds. Note that using milliseconds as a unit in unit tests
-            // prevents us from waiting 1 second on more before the timer goes off.
-            // Instead, we wait one millisecond which significantly reduces the
-            // test time.
+            // When we run unit tests, we want to use milliseconds unit for the
+            // specified interval. Otherwise, we use seconds. Note that using
+            // milliseconds as a unit in unit tests prevents us from waiting 1
+            // second on more before the timer goes off. Instead, we wait one
+            // millisecond which significantly reduces the test time.
             if (!server_->inTestMode()) {
                 fetch_time = 1000 * fetch_time;
             }
diff --git a/src/lib/process/tests/cb_ctl_base_unittests.cc b/src/lib/process/tests/cb_ctl_base_unittests.cc
index 8d75946b21..d1eabf7404 100644
--- a/src/lib/process/tests/cb_ctl_base_unittests.cc
+++ b/src/lib/process/tests/cb_ctl_base_unittests.cc
@@ -388,7 +388,7 @@ public:
 };
 
 // This test verifies that the same instance of the Config
-// Backend Manager is returned.
+// Backend Manager is returned all the time.
 TEST_F(CBControlBaseTest, getMgr) {
     auto mgr = cb_ctl_.getMgr();
     EXPECT_EQ(TEST_INSTANCE_ID, mgr.getInstanceId());