From: timeless%mac.com <>
Date: Wed, 10 Oct 2001 11:52:09 +0000 (+0000)
Subject: Bugzilla Bug 97185 make_select should add a newline after each option
X-Git-Tag: bugzilla-2.14.1~97
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5d5f0e06881ac5ed2711a3bb725f41491bcefaa7;p=thirdparty%2Fbugzilla.git

Bugzilla Bug 97185 make_select should add a newline after each option
patch by kiko. r=zach, gerv
---

diff --git a/CGI.pl b/CGI.pl
index ee6dbb4c76..2cfe767ebe 100644
--- a/CGI.pl
+++ b/CGI.pl
@@ -557,7 +557,7 @@ sub make_selection_widget {
                     } elsif ($type eq "RADIO") {
                         $popup .= "<INPUT NAME=$groupname type=radio VALUE=\"$item\" check>$displaytext<br>";
                     } else {
-                        $popup .= "<OPTION SELECTED VALUE=\"$item\">$displaytext";
+                        $popup .= "<OPTION SELECTED VALUE=\"$item\">$displaytext\n";
                     }
                     $found = 1;
                 } else {
@@ -578,7 +578,7 @@ sub make_selection_widget {
         } elsif ($type eq "RADIO") {
             $popup .= "<INPUT NAME=$groupname type=radio checked>$default";
         } else {
-            $popup .= "<OPTION SELECTED>$default";
+            $popup .= "<OPTION SELECTED>$default\n";
         }
     }
     if ($type eq "LIST") {
@@ -605,10 +605,10 @@ sub make_options {
                 }
                 $last = $item;
                 if ($isregexp ? $item =~ $default : $default eq $item) {
-                    $popup .= "<OPTION SELECTED VALUE=\"$item\">$item";
+                    $popup .= "<OPTION SELECTED VALUE=\"$item\">$item\n";
                     $found = 1;
                 } else {
-                    $popup .= "<OPTION VALUE=\"$item\">$item";
+                    $popup .= "<OPTION VALUE=\"$item\">$item\n";
                 }
             }
         }
@@ -631,7 +631,7 @@ sub make_options {
         exit 0;
               
       } else {
-	$popup .= "<OPTION SELECTED>$default";
+	$popup .= "<OPTION SELECTED>$default\n";
       }
     }
     return $popup;