From: Francis Dupont <fdupont@isc.org>
Date: Fri, 31 Mar 2023 12:01:37 +0000 (+0200)
Subject: [#2752] Added comments explaining new columns only usage
X-Git-Tag: Kea-2.3.7~48
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5d6870557e174e1c8593762fa215c716728d4e20;p=thirdparty%2Fkea.git

[#2752] Added comments explaining new columns only usage
---

diff --git a/src/share/database/scripts/mysql/dhcpdb_create.mysql b/src/share/database/scripts/mysql/dhcpdb_create.mysql
index 603a7cdca0..94741a6eb7 100644
--- a/src/share/database/scripts/mysql/dhcpdb_create.mysql
+++ b/src/share/database/scripts/mysql/dhcpdb_create.mysql
@@ -5092,6 +5092,9 @@ UPDATE schema_version
 -- This line starts the schema upgrade to version 16.
 
 -- Add relay and remote id colums to DHCPv4 leases.
+--
+-- Note: these columns are only used for indexes, in particular they are
+-- not exported by lease4 dump as values are also in the user context 
 ALTER TABLE lease4
     ADD COLUMN relay_id VARBINARY(128) DEFAULT NULL,
     ADD COLUMN remote_id VARBINARY(128) DEFAULT NULL;
diff --git a/src/share/database/scripts/mysql/upgrade_015_to_016.sh.in b/src/share/database/scripts/mysql/upgrade_015_to_016.sh.in
index 49692e7df3..05e0396162 100644
--- a/src/share/database/scripts/mysql/upgrade_015_to_016.sh.in
+++ b/src/share/database/scripts/mysql/upgrade_015_to_016.sh.in
@@ -55,6 +55,9 @@ mysql "$@" <<EOF
 -- This line starts the schema upgrade to version 16.
 
 -- Add relay and remote id colums to DHCPv4 leases.
+--
+-- Note: these columns are only used for indexes, in particular they are
+-- not exported by lease4 dump as values are also in the user context 
 ALTER TABLE lease4
     ADD COLUMN relay_id VARBINARY(128) DEFAULT NULL,
     ADD COLUMN remote_id VARBINARY(128) DEFAULT NULL;
diff --git a/src/share/database/scripts/pgsql/dhcpdb_create.pgsql b/src/share/database/scripts/pgsql/dhcpdb_create.pgsql
index 8d71d2ec0d..ea97fbc490 100644
--- a/src/share/database/scripts/pgsql/dhcpdb_create.pgsql
+++ b/src/share/database/scripts/pgsql/dhcpdb_create.pgsql
@@ -5652,6 +5652,9 @@ UPDATE schema_version
 -- This line starts the schema upgrade to version 15.
 
 -- Add relay and remote id colums to DHCPv4 leases.
+--
+-- Note: these columns are only used for indexes, in particular they are
+-- not exported by lease4 dump as values are also in the user context 
 ALTER TABLE lease4
     ADD COLUMN relay_id BYTEA DEFAULT NULL,
     ADD COLUMN remote_id BYTEA DEFAULT NULL;
diff --git a/src/share/database/scripts/pgsql/upgrade_014_to_015.sh.in b/src/share/database/scripts/pgsql/upgrade_014_to_015.sh.in
index aec3c13abe..2681e6c579 100644
--- a/src/share/database/scripts/pgsql/upgrade_014_to_015.sh.in
+++ b/src/share/database/scripts/pgsql/upgrade_014_to_015.sh.in
@@ -39,6 +39,9 @@ START TRANSACTION;
 -- This line starts the schema upgrade to version 15.
 
 -- Add relay and remote id colums to DHCPv4 leases.
+--
+-- Note: these columns are only used for indexes, in particular they are
+-- not exported by lease4 dump as values are also in the user context 
 ALTER TABLE lease4
     ADD COLUMN relay_id BYTEA DEFAULT NULL,
     ADD COLUMN remote_id BYTEA DEFAULT NULL;