From: Corey Farrell <git@cfware.com>
Date: Wed, 25 Jun 2014 18:56:09 +0000 (+0000)
Subject: ao2_container node object ignores REF_DEBUG in all places except one
X-Git-Tag: 12.4.0-rc1~27
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5d68914fa51b29f6205fce30798d4d21130b526c;p=thirdparty%2Fasterisk.git

ao2_container node object ignores REF_DEBUG in all places except one

Almost every reference operation against container node's uses
__ao2_alloc or __ao2_ref, thereby preventing ref logging for
the nodes.  One node reference is released with ao2_t_ref, causing
refcounter.py to falsely report skews and leaks for many nodes.

ASTERISK-23922 #close
Reported by: Corey Farrell
Review: https://reviewboard.asterisk.org/r/3670/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/12@417212 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/main/astobj2_container.c b/main/astobj2_container.c
index bf53d8f2a2..4d4e4749d3 100644
--- a/main/astobj2_container.c
+++ b/main/astobj2_container.c
@@ -75,7 +75,8 @@ int __container_unlink_node_debug(struct ao2_container_node *node, uint32_t flag
 	}
 
 	if (flags & AO2_UNLINK_NODE_UNREF_NODE) {
-		ao2_t_ref(node, -1, "Remove node from container");
+		/* Remove node from container */
+		__ao2_ref(node, -1);
 	}
 
 	return 1;