From: Andreas Schneider <asn@samba.org>
Date: Fri, 14 Nov 2025 09:59:19 +0000 (+0100)
Subject: s3:smbd: Fix segfault in smb2_reply
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5d77b445b354f455ea57a815e8d2c9f4e6b13585;p=thirdparty%2Fsamba.git

s3:smbd: Fix segfault in smb2_reply

This is triggered by: make test TESTS="samba3.smb2.streams.simpleserver

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15948

Pair-Programmed-With: Ralph Boehme <slow@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source3/smbd/smb2_reply.c b/source3/smbd/smb2_reply.c
index 48aa5c86038..069d447b51c 100644
--- a/source3/smbd/smb2_reply.c
+++ b/source3/smbd/smb2_reply.c
@@ -1399,7 +1399,8 @@ NTSTATUS rename_internals_fsp(connection_struct *conn,
 
 	if (fsp_is_alternate_stream(fsp)) {
 		if (newname[0] != ':') {
-			return NT_STATUS_INVALID_PARAMETER;
+			status = NT_STATUS_INVALID_PARAMETER;
+			goto out;
 		}
 
 		smb_fname_dst = synthetic_smb_fname(ctx,