From: Serge Hallyn <serge.hallyn@ubuntu.com>
Date: Tue, 20 Aug 2013 22:59:19 +0000 (-0500)
Subject: coverity: dont dereference before null check
X-Git-Tag: lxc-1.0.0.alpha1~1^2~41
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5d9598d7d3206d1bede4932e7c8565f1ab309fbc;p=thirdparty%2Flxc.git

coverity: dont dereference before null check

Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
---

diff --git a/src/lxc/bdev.c b/src/lxc/bdev.c
index 1baae89ab..fbc314b3c 100644
--- a/src/lxc/bdev.c
+++ b/src/lxc/bdev.c
@@ -243,11 +243,12 @@ static int detect_fs(struct bdev *bdev, char *type, int len)
 	pid_t pid;
 	FILE *f;
 	char *sp1, *sp2, *sp3, *line = NULL;
-	char *srcdev = bdev->src;
+	char *srcdev;
 
 	if (!bdev || !bdev->src || !bdev->dest)
 		return -1;
 
+	srcdev = bdev->src;
 	if (strcmp(bdev->type, "loop") == 0)
 		srcdev = bdev->src + 5;