From: Christopher Faulet <cfaulet@haproxy.com>
Date: Fri, 4 Jul 2025 12:34:08 +0000 (+0200)
Subject: BUG/MINOR: http-act: Fix parsing of the expression argument for pause action
X-Git-Tag: v3.3-dev3~42
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5da4da0bb62b6492c3a6fc31bd699220491bf21a;p=thirdparty%2Fhaproxy.git

BUG/MINOR: http-act: Fix parsing of the expression argument for pause action

When the "pause" action is parsed, if an expression is used instead of a
static value, the position of the current argument after the expression
evaluation is incremented while it should not. The sample_parse_expr()
function already take care of it. However, it should still be incremented
when an time value was parsed.

This patch must be backported to 3.2.
---

diff --git a/src/http_act.c b/src/http_act.c
index 106349f7c..30ed8053e 100644
--- a/src/http_act.c
+++ b/src/http_act.c
@@ -1822,8 +1822,12 @@ static enum act_parse_ret parse_http_pause(const char **args, int *orig_arg, str
                 memprintf(err, "null value is not valid for a 'pause' rule");
                 return ACT_RET_PRS_ERR;
         }
+	else {
+		/* a time volue was successfully parsed */
+		cur_arg++;
+	}
 
-	*orig_arg = cur_arg + 1;
+	*orig_arg = cur_arg;
 	return ACT_RET_PRS_OK;
 }