From: Daniel P. Berrange <berrange@redhat.com>
Date: Mon, 23 Sep 2013 13:18:04 +0000 (+0100)
Subject: Fix missing OOM check in qemuParseCommandLine when splitting strings
X-Git-Tag: v1.1.3-rc1~64
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5dd3b5e32ae7c97e820261ec9e71ebe0ffcf1719;p=thirdparty%2Flibvirt.git

Fix missing OOM check in qemuParseCommandLine when splitting strings

The qemuParseCommandLine method did not check the return value of
virStringSplit to see if OOM had occurred. This lead to dereference
of a NULL pointer on OOM.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 83597ee785..850cceaa26 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -11387,7 +11387,8 @@ qemuParseCommandLine(virCapsPtr qemuCaps,
              * Set os.machine only if first parameter lacks '=' or
              * contains explicit type='...' */
             WANT_VALUE();
-            list = virStringSplit(val, ",", 0);
+            if (!(list = virStringSplit(val, ",", 0)))
+                goto error;
             param = list[0];
 
             if (STRPREFIX(param, "type="))