From: Ben Hutchings <ben@decadent.org.uk>
Date: Mon, 6 Nov 2017 02:50:25 +0000 (+0000)
Subject: mct_u232: Fix use of uninitialized pointer in mct_u323_startup()
X-Git-Tag: v3.2.95~13
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5df98fd0a5d24fd082889eb1448cf68199f77cd9;p=thirdparty%2Fkernel%2Fstable.git

mct_u232: Fix use of uninitialized pointer in mct_u323_startup()

My backport of commit 4e9a0b05257f "USB: mct_u232: add sanity checking in
probe" incorrectly added a dev_err() call using port->dev before 'port' was
initialised.  Use the 'serial' parameter to look up the device instead.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---

diff --git a/drivers/usb/serial/mct_u232.c b/drivers/usb/serial/mct_u232.c
index ed8694b1a0f4a..8901b8d1bbe07 100644
--- a/drivers/usb/serial/mct_u232.c
+++ b/drivers/usb/serial/mct_u232.c
@@ -449,7 +449,7 @@ static int mct_u232_startup(struct usb_serial *serial)
 
 	/* check first to simplify error handling */
 	if (!serial->port[1] || !serial->port[1]->interrupt_in_urb) {
-		dev_err(&port->dev, "expected endpoint missing\n");
+		dev_err(&serial->dev->dev, "expected endpoint missing\n");
 		return -ENODEV;
 	}