From: Serhiy Storchaka <storchaka@gmail.com>
Date: Sun, 12 Jan 2025 13:14:46 +0000 (+0200)
Subject: gh-128731: Fix ResourceWarning in robotparser.RobotFileParser.read() (GH-128733)
X-Git-Tag: v3.14.0a4~31
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5e65a1acc0b630397f1d190aed279114e6e99612;p=thirdparty%2FPython%2Fcpython.git

gh-128731: Fix ResourceWarning in robotparser.RobotFileParser.read() (GH-128733)
---

diff --git a/Lib/urllib/robotparser.py b/Lib/urllib/robotparser.py
index c58565e39451..24ee198c355f 100644
--- a/Lib/urllib/robotparser.py
+++ b/Lib/urllib/robotparser.py
@@ -65,6 +65,7 @@ class RobotFileParser:
                 self.disallow_all = True
             elif err.code >= 400 and err.code < 500:
                 self.allow_all = True
+            err.close()
         else:
             raw = f.read()
             self.parse(raw.decode("utf-8").splitlines())
diff --git a/Misc/NEWS.d/next/Library/2025-01-11-13-40-12.gh-issue-128731.qpKlai.rst b/Misc/NEWS.d/next/Library/2025-01-11-13-40-12.gh-issue-128731.qpKlai.rst
new file mode 100644
index 000000000000..b23499ca2fea
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2025-01-11-13-40-12.gh-issue-128731.qpKlai.rst
@@ -0,0 +1 @@
+Fix :exc:`ResourceWarning` in :meth:`urllib.robotparser.RobotFileParser.read`.