From: Christopher Faulet <cfaulet@haproxy.com>
Date: Wed, 22 Jun 2022 15:12:05 +0000 (+0200)
Subject: BUG/MINOR: http-ana: Set method to HTTP_METH_OTHER when an HTTP txn is created
X-Git-Tag: v2.7-dev1~11
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5eb67f5d7400fce75cf429d09af31464ed0eabfc;p=thirdparty%2Fhaproxy.git

BUG/MINOR: http-ana: Set method to HTTP_METH_OTHER when an HTTP txn is created

This patch is required to fix "method" sample fetch. But it make sense to
initialize the method of an HTTP transaction to HTTP_METH_OTHER. This way,
before the request parsing, the method is considered as unknown except if we
are able to retrieve the request start-line. It is especially important for
TCP streams.

About the "method" sample fetch, this patch is a way to be sure no random
method is returned when the sample fetch is used on a TCP stream before any
HTTP parsing.

This patch must be backported as far as 2.0.
---

diff --git a/src/http_ana.c b/src/http_ana.c
index 60a86f9c21..021ad753b4 100644
--- a/src/http_ana.c
+++ b/src/http_ana.c
@@ -5206,6 +5206,7 @@ struct http_txn *http_create_txn(struct stream *s)
 		return NULL;
 	s->txn = txn;
 
+	txn->meth = HTTP_METH_OTHER;
 	txn->flags = ((sc && sc_ep_test(sc, SE_FL_NOT_FIRST)) ? TX_NOT_FIRST : 0);
 	txn->status = -1;
 	txn->http_reply = NULL;