From: Amos Jeffries Date: Sat, 21 Sep 2024 20:27:11 +0000 (+0000) Subject: Remove Edge Side Include (ESI) protocol (#1905) X-Git-Tag: SQUID_7_0_1~60 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5eb89ef3;p=thirdparty%2Fsquid.git Remove Edge Side Include (ESI) protocol (#1905) ESI feature has a number of bugs and security vulnerabilities. It is also rarely used and a survey of active community members has not revealed a need to keep maintaining this code. --- diff --git a/CREDITS b/CREDITS index 52ebd70e96..d26f68ba0c 100644 --- a/CREDITS +++ b/CREDITS @@ -1522,15 +1522,6 @@ src/auth/ntlm/smb_lm/: ============================================================================== -src/esi/Libxml2Parser.cc, -src/esi/Libxml2Parser.h: - - * The ESI Libxml2 parser is Copyright (c) 2004 by Joachim Bauch - * http://www.joachim-bauch.de - * mail@joachim-bauch.de - -============================================================================== - src/external_acl.c: Copyright (C) 2002 MARA Systems AB, Sweden diff --git a/configure.ac b/configure.ac index 285f05349e..19a5cbe7f8 100644 --- a/configure.ac +++ b/configure.ac @@ -817,38 +817,6 @@ AC_ARG_ENABLE(delay-pools, dnl disable generic/common adaptation support by default squid_opt_use_adaptation=no -AH_TEMPLATE([USE_SQUID_ESI],[whether to enable ESI processing]) -AC_ARG_ENABLE(esi,[ - AS_HELP_STRING([--enable-esi], - [Enable ESI for accelerators. ESI requires expat or xml2 library. - Enabling ESI will cause squid reverse proxies to be capable - of the Edge Acceleration Specification (www.esi.org).]) -],[ - SQUID_DEFINE_BOOL(USE_SQUID_ESI,$enable_esi) -]) -AC_MSG_NOTICE([Enable ESI processor: ${enable_esi:=no (auto)}]) - -# ESI support libraries: expat -SQUID_AUTO_LIB(expat,[ESI expat library],[LIBEXPAT]) -SQUID_CHECK_LIB_WORKS(expat,[ - PKG_CHECK_MODULES([LIBEXPAT],[expat],[:],[:]) - CPPFLAGS="$LIBEXPAT_CFLAGS $CPPFLAGS" - AC_CHECK_HEADERS(expat.h) -]) - -# ESI support libraries: xml2 -SQUID_AUTO_LIB(xml2,[ESI xml2 library],[LIBXML2]) -SQUID_CHECK_LIB_WORKS(xml2,[ - PKG_CHECK_MODULES([LIBXML2],[libxml-2.0],[:],[:]) - CPPFLAGS="$LIBXML2_CFLAGS $CPPFLAGS" - AC_CHECK_HEADERS(libxml/parser.h libxml/HTMLparser.h libxml/HTMLtree.h) -]) - -AS_IF([test "x$enable_esi" = "xyes" -a "x$LIBXML2_LIBS" = "x" -a "x$LIBEXPAT_LIBS" = "x"],[ - AC_MSG_ERROR([ESI processor requires libxml2 or libexpat]) -]) -AM_CONDITIONAL(ENABLE_ESI,[test "x$enable_esi" = "xyes"]) - AC_ARG_ENABLE(icap-client, AS_HELP_STRING([--disable-icap-client],[Disable the ICAP client.]),[ SQUID_YESNO([$enableval],[--enable-icap-client]) @@ -2519,8 +2487,6 @@ AC_CONFIG_FILES([ errors/Makefile icons/Makefile lib/Makefile - lib/libTrie/Makefile - lib/libTrie/test/Makefile lib/ntlmauth/Makefile lib/rfcnb/Makefile lib/smblib/Makefile @@ -2587,7 +2553,6 @@ AC_CONFIG_FILES([ src/DiskIO/IpcIo/Makefile src/DiskIO/Mmapped/Makefile src/error/Makefile - src/esi/Makefile src/eui/Makefile src/format/Makefile src/fs/Makefile diff --git a/doc/Programming-Guide/03_MajorComponents.dox b/doc/Programming-Guide/03_MajorComponents.dox index ce6a6606c9..f52ae3d931 100644 --- a/doc/Programming-Guide/03_MajorComponents.dox +++ b/doc/Programming-Guide/03_MajorComponents.dox @@ -338,11 +338,4 @@ TODO: get RFCs linked from ietf see (http://squid.nlanr.net/Squid/urn-support.html) URN Support in Squid . -\section ESI ESI -\par - ESI is an implementation of Edge Side Includes (http://www.esi.org). - ESI is implemented as a client side stream and a small - modification to client_side_reply.c to check whether - ESI should be inserted into the reply stream or not. - */ diff --git a/doc/debug-sections.txt b/doc/debug-sections.txt index 892042ae2c..3fdfd0e16a 100644 --- a/doc/debug-sections.txt +++ b/doc/debug-sections.txt @@ -138,8 +138,6 @@ section 83 TLS Server/Peer negotiation section 83 TLS session management section 84 Helper process maintenance section 85 Client-side Request Routines -section 86 ESI Expressions -section 86 ESI processing section 87 Client-side Stream routines. section 88 Client-side Reply Routines section 89 EUI-48 Lookup diff --git a/doc/release-notes/release-7.sgml.in b/doc/release-notes/release-7.sgml.in index e3150e65ff..f33c9992d6 100644 --- a/doc/release-notes/release-7.sgml.in +++ b/doc/release-notes/release-7.sgml.in @@ -199,6 +199,9 @@ This section gives an account of those changes in three categories: Removed directives