From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 24 Jul 2025 22:24:23 +0000 (-0700)
Subject: fixup! submodule: skip redundant active entries when pattern covers path
X-Git-Tag: v2.51.0-rc1~6^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5ed8c5b465aaeae967875d043187668bdc0dfe54;p=thirdparty%2Fgit.git

fixup! submodule: skip redundant active entries when pattern covers path
---

diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index 08a808e5c4..10cd65e343 100644
--- a/builtin/submodule--helper.c
+++ b/builtin/submodule--helper.c
@@ -3330,10 +3330,9 @@ static void configure_added_submodule(struct add_data *add_data)
 	char *key;
 	struct child_process add_submod = CHILD_PROCESS_INIT;
 	struct child_process add_gitmodules = CHILD_PROCESS_INIT;
-
 	const struct string_list *values;
-	size_t i;
 	int matched = 0;
+
 	key = xstrfmt("submodule.%s.url", add_data->sm_name);
 	git_config_set_gently(key, add_data->realrepo);
 	free(key);
@@ -3385,7 +3384,7 @@ static void configure_added_submodule(struct add_data *add_data)
 		git_config_set_gently(key, "true");
 		free(key);
 	} else {
-		for (i = 0; i < values->nr; i++) {
+		for (size_t i = 0; i < values->nr; i++) {
 			const char *pat = values->items[i].string;
 			if (!wildmatch(pat, add_data->sm_path, 0)) { /* match found */
 				matched = 1;