From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Fri, 26 May 2017 01:55:29 +0000 (-0400)
Subject: CID 1409868: Check return of cf_data_find
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5f158df41e47f1bb14f2b541d17518cac70dbb5e;p=thirdparty%2Ffreeradius-server.git

CID 1409868: Check return of cf_data_find
---

diff --git a/src/modules/proto_radius/proto_radius.c b/src/modules/proto_radius/proto_radius.c
index bba931e1265..b88ba521ece 100644
--- a/src/modules/proto_radius/proto_radius.c
+++ b/src/modules/proto_radius/proto_radius.c
@@ -337,6 +337,10 @@ static int mod_parse(fr_schedule_t *handle, CONF_SECTION *cs, bool verify_config
 			value = cf_pair_value(cp);
 
 			module = cf_data_find(cs, dl_t, value);
+			if (!module) {
+				cf_log_err_cs(cs, "Section missing module data");
+				return -1;
+			}
 			if (cf_data_find(cs, char const *, value)) continue;
 
 			app = (fr_app_subtype_t const *) module->common;